Properly resolve HTTP methods #1767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0vi
force-pushed
the
replace-deprecated-httpmethod-resolve
branch
from
6ccb0a4
to
ee48bd0
Compare
d0vi
changed the title
On Spring Framework 5 `HttpMethod` is an enum type that exposes a `resolve(java.lang.String)` method that matches the String value passed with the enum value while handling null values gracefully. However, in the context of `toValidHttpMethod(java.lang.String)`, there is a previous assertion that ensures `null` will not be passed moving forward. Hence, using enum's native `valueOf` directly seems like a good idea. Furthermore, Spring Framework 6.0 marked `HttpMethod#resolve(java.lang.String)` as deprecated for removal, and starting from Spring Framework 6.1 this API element no longer exists. This change is currently causing issues (rest-assured#1760) with latest Spring Framework and Spring Boot versions. This commit replaces the use of this method with the equivalent `HttpMethod#valueOf(java.lang.String)`. Closes rest-assured#1760.
d0vi
force-pushed
the
replace-deprecated-httpmethod-resolve
branch
from
ee48bd0
to
35e02f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Spring Framework 5
HttpMethodis an enum type that exposes aresolve(java.lang.String)method that matches the String value passed with the enum value while handling null values gracefully. However, in the context oftoValidHttpMethod(java.lang.String), there is a previous assertion that ensuresnullwill not be passed moving forward. Hence, using enum's nativevalueOfdirectly seems like a good idea.Furthermore, Spring Framework 6.0 marked
HttpMethod#resolve(java.lang.String)as deprecated for removal, and starting from Spring Framework 6.1 this API element no longer exists. This change is currently causing issues (#1760) with latest Spring Framework and Spring Boot versions.This commit replaces the use of this method with the equivalent
HttpMethod#valueOf(java.lang.String).Closes #1760.