Feature/json b3 #1742
Feature/json b3 #1742
Conversation
| @Test | ||
| public void |
There was a problem hiding this comment.
I think it is generally a good idea to respect whatever formatting conventions the repository has adopted. We are just guests here and so we should not tell the host to re-organize his cupboard because we are like it differently.
It would also be much easier to review without the formatting changes.
There was a problem hiding this comment.
True. Auto format on save is my problem. Will revert the format.
pom.xml
Outdated
| </ignoredClassPatterns> | ||
| </configuration> | ||
| </plugin> | ||
| <!-- TODO return off this beautifull plugin--> |
There was a problem hiding this comment.
Yes as a reminder to add the plugin back once finished. Can you help me with this one?
There was a problem hiding this comment.
Sorry, no idea what it is supposed to be doing.
|
@ppalaga going for J11, means the modules of Spring can't be updatet to Spring (Security) 6 as they require J17. I made a start on that upgrade, but will revert for now. That should be a different PR. |
Hm... REST assured itself depends on Spring? Is it not only only tests or examples? If so, the core can be at |
appiepollo14
force-pushed
the
feature/json-b3
branch
from
b602b50
to
2980d04
Compare
|
@ppalaga @johanhaleby I'm a bit stuck at this point. I've reverted a lot of changes, and focussed on the core changes to hopefully enable jsonb-3 support. The code at this point uses Yasson 3.0 and a lot of dependencies were updatet. Updates java version to 11. Can do a mvn clean package without an issue. When doing mvn Verify, the module: rest-assured-itest-java does not compile completely. A few tests fail, because a Java exception is expected, but a groovy.runtime exception is thrown referencing that java exception. I assume this is groovy behavior introduced by using the gmavenplus plugin?? Not familiar with this, please help. Besides this, when doing a mvn install, I've the new RA version locally. When using that version in a JEE10 project, I still get the error: JSONB-3 is not found on the classpath. So I have my doubts whether what I'm doing is enough to support JSONB-3. Any thoughts on this? kind regards, Asjer |
appiepollo14
force-pushed
the
feature/json-b3
branch
from
a1b08f9
to
358a90c
Compare
# Conflicts: # json-path/pom.xml # pom.xml # rest-assured-common/pom.xml # rest-assured/pom.xml # xml-path/pom.xml
appiepollo14
force-pushed
the
feature/json-b3
branch
from
a20559c
to
b798eab
Compare
#1651 draft for upgrading to json-b3