Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Spring Framework 5
HttpMethod
is an enum type that exposes aresolve(java.lang.String)
method that matches the String value passed with the enum value while handling null values gracefully. However, in the context oftoValidHttpMethod(java.lang.String)
, there is a previous assertion that ensuresnull
will not be passed moving forward. Hence, using enum's nativevalueOf
directly seems like a good idea.Furthermore, Spring Framework 6.0 marked
HttpMethod#resolve(java.lang.String)
as deprecated for removal, and starting from Spring Framework 6.1 this API element no longer exists. This change is currently causing issues (#1760) with latest Spring Framework and Spring Boot versions.This commit replaces the use of this method with the equivalent
HttpMethod#valueOf(java.lang.String)
.Closes #1760.