Tests for vocabulary-dataset relationship CRUD operations #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 19, 2019 14:02
tiagojsag
suggested changes
Nov 19, 2019
There was a problem hiding this comment.
Left you a few notes throughout the code. A couple more thing I think can be improved:
- I saw a lot of "...should be successful" on the test case name. IMO those should be made clearer, like "...should return a HTTP code 200 and the dataset object" so it's clear what "success" means in each case
- I see you commented your code thoroughly, which is great, but perhaps we don't need these many comments. Save them for more convoluted lines, where the behavior is not directly clear, or there's a weird reason why the code has to be that way. This is more of a time saver than a deal-breaker, feel free to document as much as you want if you want, no objections from me on that ;)
ikas
force-pushed
the
hp-vocabulary-tests
branch
from
4cb296e
to
9aaa8fa
Compare
tiagojsag
suggested changes
Nov 20, 2019
added 4 commits
November 20, 2019 10:17
tiagojsag
suggested changes
Nov 21, 2019
| }); | ||
|
|
||
| after(async () => { | ||
| await Resource.deleteMany().exec(); |
There was a problem hiding this comment.
Can you move all of these from before to beforeEach and from after to afterEach? Initially, I had it like this, but then JS's asynchronous nature came to bite me in the ass, as things were happening in weird orders. Thus I started moving towards cleaning up the model in between tests, to ensure all of them are self contained, and dont depend on each other.
There was a problem hiding this comment.
Done, had to make some changes in the find-by-ids test suite, but it was an easy change 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.