Add support for Feign 12.5+ #2127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is applied to the 1.7 branch, as I need this fixed in 1.7, if this is approved and we create a new 1.7.x release I am happy to port these changes to 2.0 branch =) |
nilo85
force-pushed
the
1.7-feign-12.5-fixes
branch
from
730c51d
to
62d2175
Compare
Feign 12.5 made the builder.build() method final, and started internally clone it... This breaks resilience4j integration with feign and renders resilience4j completely unused by feign. In version 10.9 they introduced an api to add "capabilities" to the feign client. Here I have made changed to the 1.7 branch (the release I need) that implements this new pattern instead, and provides a fallback using old pattern for backwards compatibility down to 10.9. Merging this means minimum version of feign to use would be 10.9. and works with latest
nilo85
force-pushed
the
1.7-feign-12.5-fixes
branch
from
62d2175
to
4274ac4
Compare
Closed
|
Yes, porting this to 2.x would be appreciated as well :) |
andrzejsydor
approved these changes
Mar 6, 2024
|
follow up for 2.0 branch #2129 (simple cherry-pick seems to be enough) |
|
follow up for master branch #2130 |
AlessandroBagnoli
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feign 12.5 made the builder.build() method final, and started internally clone it...
This breaks resilience4j integration with feign and renders resilience4j completely unused by feign.
In version 10.9 they introduced an api to add "capabilities" to the feign client.
Here I have made changed to the 1.7 branch (the release I need) that implements this new pattern instead, and provides a fallback using old pattern for backwards compatibility down to 10.9.
Merging this means minimum version of feign to use would be 10.9. and works with latest