Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reactor bulkhead blocking #1714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix reactor bulkhead blocking #1714

wants to merge 1 commit into from

Conversation

1livv
Copy link

@1livv 1livv commented Jul 5, 2022 •
edited

Fixes #1592

  • added Bulkhead#tryAcquirePermissionNoWait which tries to acquire a permit from the underlying semaphore without waiting
  • added ReactiveBulkhead which wraps a Bulkhead in a non blocking way
  • refactored BulkheadOperator to use ReactiveBulkhead and Mono.usingWhen/Flux.usingWhen

@1livv
Copy link
Author

1livv commented Jul 5, 2022

@RobWin can you take a look, is this approach ok?

@1livv 1livv force-pushed the fix_reactor_bulkhead_blocking branch from 01dc285 to 16606eb Compare July 6, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reactor Bulkhead operator blocks if max wait duration is set
1 participant
@1livv