Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release r4.0.0 #1127

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Release r4.0.0 #1127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71c2490
Starting of new release
akshatmittal Apr 26, 2024
f28d127
Merge branch 'master' into 4.0.0
akshatmittal May 30, 2024
a21fedd
fix GnosisTrade approval (#1150)
tbrent May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/mixins/Versioned.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pragma solidity 0.8.19;
import "../interfaces/IVersioned.sol";

// This value should be updated on each release
string constant VERSION = "3.4.0";
string constant VERSION = "4.0.0";

/**
* @title Versioned
Expand Down
2 changes: 1 addition & 1 deletion contracts/plugins/trading/GnosisTrade.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ contract GnosisTrade is ITrade, Versioned {
//
// Context: wcUSDCv3 has a non-standard approve() function that reverts if the approve
// amount is > 0 and < type(uint256).max.
AllowanceLib.safeApproveFallbackToMax(address(sell), address(gnosis), initBal);
AllowanceLib.safeApproveFallbackToMax(address(sell), address(gnosis), req.sellAmount);

auctionId = gnosis.initiateAuction(
sell,
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export const ORACLE_ERROR = fp('0.01') // 1% oracle error
export const REVENUE_HIDING = fp('0') // no revenue hiding by default; test individually

// This will have to be updated on each release
export const VERSION = '3.4.0'
export const VERSION = '4.0.0'

export type Collateral =
| FiatCollateral
Expand Down