Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js requirement to the latest LTS (v20) #6684

Closed
wants to merge 1 commit into from

Conversation

cometkim
Copy link
Contributor

#6429 merged, then why not jump directly to the latest LTS?

It has a longer lifespan and several more stable APIs that are useful for development.

And I think upgrading an old version of node to v18 or v20 isn't much different.

@cometkim cometkim changed the title Jump Node.js requirement to the latest LTS (v20) Update Node.js requirement to the latest LTS (v20) Mar 17, 2024
@DZakh
Copy link
Contributor

DZakh commented Mar 18, 2024

I think upgrading to v18 is already challenging for many users.

@cometkim
Copy link
Contributor Author

True, but upgrading to v18 is no easier than upgrading to v20 unless there are surfaces that were removed in v18. AFIAK, it doesn't exist.

@cometkim
Copy link
Contributor Author

In fact, the compiler itself did not perform any migrations while upgrading the old Node.js codebase to v18 and v20.

Looking back on my production experience, one of the cases I can remember along the way was upgrading node-sass dependency using node-gyp. It had simply done by update dependency version.

Another thing is that since Node.js v15, the global handling of unhandledRejection event changed from warning to throw. (there was deprecation warning for long time)

From v18 to v20, there are no major issues that I have experienced. Rather, I requested to switch to v20 as soon as possible to resolve the memory leak of fetch added in v18.

@cknitt
Copy link
Member

cknitt commented Mar 19, 2024

I am a bit hesitant about this. Node 18 is still supported until April 2025, and this change does not bring any benefit to ReScript users.

I think it is ok if we use Node 20 internally for our development/CI scripts if we find that it brings any advantage, but we should not force it on our users (yet).

@cometkim cometkim marked this pull request as draft March 25, 2024 08:42
@cknitt cknitt closed this May 26, 2024
@cometkim cometkim deleted the jump-to-lts branch May 26, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants