Fix parsing of partial application with pipe #6325
Conversation
| | DotDotDot when args <> [] -> | ||
| | DotDotDot -> |
There was a problem hiding this comment.
Is there any reason for this restriction beyond the fact that f(...) can simple be reduced to f (if not piped)? Is it safe to remove it?
| (ReactEvent.Mouse.t -> unit, [ `Has_arity1 ]) function$ as 'callback | ||
| let partialPipe = x |.u ((f ())[@res.partial ][@res.uapp ]) |
There was a problem hiding this comment.
Not sure about the (). Try an example and see if it type checks correctly.
There was a problem hiding this comment.
Indeed, it shouldn't be there. But if I remove it, the above end up as:
let partialPipe = x |.u fSeems the whole apply expression is replaced by just the function identifier, which makes sense in itself of course, but that also means the attributes are dropped. Might not be so easy to fix this one.
There was a problem hiding this comment.
Yes looks like fixing this one is more complicated and might need to involve the processing of the partial attribute later in the compiler.
E.g. conceptually I guess the attribute belongs to |.u in that example. Or perhaps putting it on f is fine.
Guess it does not matter much -- just some representation picked up deeper down in the compiler.
Not sure if this is an appropriate fix, but if it is I also need to fix printing.
Fixes #6321