Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate simpler code #6273

Merged
merged 11 commits into from May 13, 2024
Merged

Generate simpler code #6273

merged 11 commits into from May 13, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented May 9, 2024

What

My attempt at making the generated rust code shorter and more readable.
Because I couldn't sleep.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🦀 Rust API Rust logging API codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 9, 2024
@emilk emilk marked this pull request as draft May 9, 2024 09:04
@emilk emilk marked this pull request as ready for review May 9, 2024 12:21
@rerun-io rerun-io deleted a comment from github-actions bot May 9, 2024
@rerun-io rerun-io deleted a comment from github-actions bot May 9, 2024
@emilk
Copy link
Member Author

emilk commented May 9, 2024

@rerun-bot full-check

Copy link

github-actions bot commented May 9, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/9022469408

@teh-cmc teh-cmc self-requested a review May 13, 2024 09:16
# Conflicts:
#	crates/re_types/src/blueprint/components/active_tab.rs
#	crates/re_types/src/blueprint/components/included_content.rs
#	crates/re_types/src/blueprint/components/query_expression.rs
#	crates/re_types/src/blueprint/components/space_view_class.rs
#	crates/re_types/src/blueprint/components/space_view_origin.rs
#	crates/re_types/src/components/media_type.rs
#	crates/re_types/src/components/name.rs
#	crates/re_types/src/components/text.rs
#	crates/re_types/src/components/text_log_level.rs
#	crates/re_types/src/datatypes/tensor_dimension.rs
@emilk emilk merged commit 3dc64f9 into main May 13, 2024
34 checks passed
@emilk emilk deleted the emilk/better-codegen branch May 13, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants