New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate simpler code #6273
Merged
Merged
Generate simpler code #6273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🦀 Rust API
Rust logging API
codegen/idl
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
May 9, 2024
emilk
force-pushed
the
emilk/better-codegen
branch
from
May 9, 2024 09:09
bd78575
to
67d517e
Compare
emilk
force-pushed
the
emilk/better-codegen
branch
from
May 9, 2024 19:25
67d517e
to
91c6d9d
Compare
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9022469408 |
teh-cmc
approved these changes
May 13, 2024
# Conflicts: # crates/re_types/src/blueprint/components/active_tab.rs # crates/re_types/src/blueprint/components/included_content.rs # crates/re_types/src/blueprint/components/query_expression.rs # crates/re_types/src/blueprint/components/space_view_class.rs # crates/re_types/src/blueprint/components/space_view_origin.rs # crates/re_types/src/components/media_type.rs # crates/re_types/src/components/name.rs # crates/re_types/src/components/text.rs # crates/re_types/src/components/text_log_level.rs # crates/re_types/src/datatypes/tensor_dimension.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
codegen/idl
exclude from changelog
PRs with this won't show up in CHANGELOG.md
🦀 Rust API
Rust logging API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
My attempt at making the generated rust code shorter and more readable.
Because I couldn't sleep.
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.