Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen Rust comments #6272

Merged
merged 3 commits into from May 13, 2024
Merged

Codegen Rust comments #6272

merged 3 commits into from May 13, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented May 9, 2024

What

Reading the generated Rust code is… difficult.
Trying to map some generated piece of code to the code that generated that is likewise difficult.
With this PR we can start sprinkle in comments where it makes sense.

This is what I do when I wake up at 4am and can't fall back to sleep. Code quality might reflect that.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🦀 Rust API Rust logging API codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 9, 2024
@teh-cmc teh-cmc self-requested a review May 13, 2024 09:13
@emilk emilk merged commit 43feb6d into main May 13, 2024
34 checks passed
@emilk emilk deleted the emilk/codegen-comments branch May 13, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants