Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some clones in the generated arrow serializer #6249

Merged
merged 7 commits into from May 13, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented May 7, 2024

What

No huge wins

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🦀 Rust API Rust logging API 📉 performance Optimization, memory use, etc codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 7, 2024
@emilk
Copy link
Member Author

emilk commented May 7, 2024

@rerun-bot full-check

Copy link

github-actions bot commented May 7, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/8983184913

@emilk emilk marked this pull request as ready for review May 7, 2024 10:30
@teh-cmc teh-cmc self-requested a review May 13, 2024 09:08
@emilk emilk merged commit f7ea2bb into main May 13, 2024
34 checks passed
@emilk emilk deleted the emilk/optimize-arrow-serializer branch May 13, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md 📉 performance Optimization, memory use, etc 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants