Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wgpu to 0.20 #6171

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Update wgpu to 0.20 #6171

wants to merge 3 commits into from
+186 −187

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Apr 30, 2024 •
edited

What

⚠️ Updates egui & egui_commonmark to a git revision
⚠️ Let's not merge this before 0.16 since these updates bear significant risks

Test on:

  • Mac
    • native
    • Firefox WebGL
    • Chrome WebGPU
    • Chrome WebGL
  • Windows
    • native
    • Firefox WebGL
    • Chrome WebGPU
    • Chrome WebGL
  • Linux
    • native
    • Firefox WebGL
    • Chrome WebGPU
    • Chrome WebGL

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🪳 bug Something isn't working do-not-merge Do not merge this PR dependencies concerning crates, pip packages etc labels Apr 30, 2024
emilk
emilk reviewed May 2, 2024
View reviewed changes
crates/re_renderer/src/error_handling/error_tracker.rs
Comment on lines +109 to +113
wgpu::Error::Internal {
source: _source,
description,
}
| wgpu::Error::Validation {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we care about the difference between these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm I thought no, but I think now you're actually right. Validation means we messed up with the inputs we gave to wgpu/webgpu whereas Internal means that either the wgpu/webgpu messed up and/or a driver isn't behaving as expected

@Wumpf
Copy link
Member Author

Wumpf commented May 15, 2024 •
edited

Given the amount of failures and fixes pending on wgpu, we want to wait for wgpu 0.20.1

@Wumpf Wumpf marked this pull request as draft May 15, 2024 08:48
@Wumpf
Copy link
Member Author

Wumpf commented May 18, 2024

essentially waiting for gfx-rs/wgpu#5681 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk left review comments

Assignees
No one assigned
Labels
🪳 bug Something isn't working dependencies concerning crates, pip packages etc do-not-merge Do not merge this PR
Projects
None yet
Milestone
No milestone
2 participants
@Wumpf @emilk