Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RQ-245] fix: network table flickering issues fix #578

Merged
merged 4 commits into from
Apr 30, 2023
Merged

[RQ-245] fix: network table flickering issues fix #578

merged 4 commits into from
Apr 30, 2023

Conversation

wrongsahil
Copy link
Member

@wrongsahil wrongsahil commented Apr 30, 2023 •
edited

📜 Summary of changes:

Improves Desktop app Network Table Virtualization performance. Reference bvaughn/react-window#60 (comment)

✅ Checklist:

  • Make sure linting and unit tests pass.
  • No install/build warnings introduced.
  • Verified UI in browser.
  • For UI changes, added/updated analytics events (if applicable).
  • For changes in extension's code, manually tested in Chrome and Firefox.
  • For changes in extension's code, both MV2 and MV3 are covered.
  • Added/updated unit tests for this change.
  • Raised pull request to update corresponding documentation (if already exists).

🧪 Test instructions:

🔗 Other references:

@sagarsoni7 sagarsoni7 self-requested a review April 30, 2023 13:55
@wrongsahil wrongsahil merged commit a76d1c8 into master Apr 30, 2023
@wrongsahil wrongsahil deleted the fix-network-table-virtualization branch April 30, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagarsoni7 sagarsoni7 sagarsoni7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wrongsahil @sagarsoni7