New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENGG-1682] feat: rules executions support; extension icon green, executed rules in popup #1671
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
browser-extension/mv3/src/service-worker/services/extensionIconManager.ts
Show resolved
Hide resolved
case RuleType.CANCEL: | ||
case RuleType.DELAY: | ||
rule.pairs.forEach((pair) => { | ||
if (matchSourceUrl(pair.source, details.url)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only URL is being matched. We would also need to match source filters: resourceType, requestMethod and pageDomain/initiator domain
browser-extension/mv3/src/service-worker/services/ruleExecutionHandler.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DNR rules have excludedInitiatorDomains
"excludedInitiatorDomains": [
"requestly.io"
]
So, we should also not check rule matches for requestly
initiator domains
8757157
to
8cc6028
Compare
Closes issue:
π Summary of changes:
β Checklist:
π§ͺ Test instructions:
π Other references: