New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support named parameters for prepared statements #838
base: master
Are you sure you want to change the base?
Conversation
…Customizing insert, update sql statement (ex. Apache Phoenix support `UPSERT` only)
# Conflicts: # requery/src/main/java/io/requery/sql/platform/Generic.java
Will look this over thanks! |
} | ||
} | ||
|
||
private class EntityResult extends BaseResult<E> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks identical to RawEntityQuery.EntityResult
this class should probably extend RawEntityQuery to avoid duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I change RawEntityQuery overridable? If then, I will
* @author debop (Sunghyouk Bae) | ||
* @since 18. 12. 8 | ||
*/ | ||
public class RawTupleNamedQuery extends PreparedQueryOperation implements Supplier<Result<Tuple>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly this duplicates much RawTupleQuery so probably should extend it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I change RawTupleQuery to overridable, I will extend it
Support named parameters like this
and support duplicated parameters