Fix postgres db custom schema option not working #6708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Irmo van den Berge <i.vdberge@valtes.nl>
|
Added a change to only create the custom schema if it doesn't already exist. CREATE IF NOT EXISTS does not work by itself because the user requires CREATE permission on the database for it to work. When granting limited priviliges to the wiki database user this is undesirable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered an issue when trying to configure a postgres DB schema, which was needed for integration with supabase. This was caused by knex migration scripts not having this same schema configured, and this custom schema not being created at startup.
This PR fixes both issues and allows for a successful startup and initialization of the wiki server.
I did notice that this option, while it exists in the code, isn't documented in the docs. It is set by using a config.yml with db.schema set, and I don't think it has an env parsing default. This might be something worth improving in the future.