fix: builtin func refactor for github #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmvaldivia
added
bug
wtfiscrq
requested changes
Jun 17, 2022
| func buildRequestUrl(path string, data map[string]any) (string, error) { | ||
| pathParams := parsePathParams(path) | ||
|
|
||
| if len(pathParams) != 0 { |
There was a problem hiding this comment.
I believe this condition is not necessary. If pathParams is empty the for isn't executed anyway.
| u.RawQuery = qs.Encode() | ||
|
|
||
| return r.Client.NewRequest(method, u.String(), nil) | ||
| return u.String(), err |
There was a problem hiding this comment.
I think it's better to return nil here instead of err. Telling explicitly there was no error (err can have a value that we handled and we'd be returning it anyway).
| } | ||
| } | ||
|
|
||
| //Testing request path strings to url request |
There was a problem hiding this comment.
Missed the space between the // and comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interface{}toanyin the changed files