Only delete site entries that are new to letsencrypt #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role currently deletes all entries out of sites-enabled upon each run, disrupting the ability for nginx to serve sites while ansible is running. It also means it never converges if there are any letencrypt sites.
I'm not certain why it's necessary to delete these in the first place. My guess is that these entries are deleted in preparation of an all-new letsencrypt cert, since we need to create a valid nginx entry for the domain but do not yet have an cert and key to reference.
This change makes it so it only acts on site.file_names that are new to letsencrypt.