Atl partial's overhaul and fix #5237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name is quater, Gamma-quater The commented lines only waste execution time until all kinds of parameters are allowed, but they are intended to be included when all parameters are.
This was referenced Jan 2, 2024
|
This removes the last external call to ParameterInfo.legacy and paves the way to nuking it or maybe merge it with the unpickling mechanism (reducing the number of methods dedicated to that process). |
|
The (minor) behavior changes are not documented in the main doc, only in incompat. If that's all right, it will be part of #5238 to catch it all in one go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses most of the main points of #5102, and #4371.
The parameters that get fixed are still forbidden though, as are var-pos and var-kw parameters. That will be for another PR. But the implementation that goes with handling those is already here, commented-out for performance.
The solution to #4405 is there too but also commented out. That change will also go in separately.