Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of a PR intended to add functionality to NVL which is already included for ADV mode - namely, the ability to specify a particular screen for NVL choice menus and characters. The idea behind this is so people can style NVL in multiple ways across their game.
Included in the PR at the moment:
config.menu_arguments_callback
to specify thenvl
argument to menus.dialogue
lists, but this is likely out of the scope of this PRThings I would like assistance with before this PR is merged:
nvl_show_core
should be refactored to show the screen associated with the last NVL dialogue speaker. I achieved a close-to-desired result with the following code:(In
push_nvl_list
)(In
nvl_show_core
)I wasn't sure if this was the right approach however, so I've omitted it from the PR. I'd still like the ability to specify an NVL screen even without this functionality, so long as dialogue window management can prevent other NVL screens from flashing (which it currently cannot; the original NVL will always flash either at the start of a
window show
statement or between choice menus unlesswindow show
is active).