Reform the Render.blit API #4430
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want the pos to be rounded, blit's old job, you can call integer_blit. Converting to pure-floats is useless, since nothing checks, so subpixel_blit is made an alias of absolute_blit which uses the good type. The base behavior is to take elements of pos as style and transform properties do : as positions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit may be cherrypicked on its own.
I initially planned to have
blit = _blitin the class body and have the compat edit the class withblit = integer_blit, but unfortunately you can't edit classes out of pyx files.This also needs to be tested.
There is also the issue that the blit method is used a lot internally, and was used in the perspective of the pos being rounded to int.
These need to be checked, and I believe the simplest way forward would be to add an integer_blit method and massively rename dubious entries in the repo to using that one. (dubious meaning not calling it with literal
(0, 0)as the pos or other simple cases)I'll wait for confirmation before doing that though.
An argument could be made (and easily won, in my opinion) to drop subpixel_blit, since it's now replaced with absolute_blit.