Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call render_async logic if document state is ready or interactive #114

Merged
merged 1 commit into from
May 9, 2020

Conversation

nikolalsvk
Copy link
Collaborator

Based on the comment from here #70 (comment), nested partials were not loading with Turbolinks.

By tracking whether the document state is 'completed' or 'interactive', nested render_async logic will perform instead of waiting for turbolinks:load event like it does on the first-page load.

@nikolalsvk nikolalsvk merged commit 139949b into master May 9, 2020
@nikolalsvk nikolalsvk deleted the render-nested-partials-with-turbolinks branch May 9, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant