Replace graphql-request with fetch #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphql-request is big package and depends on graphql. Practically it does not do anything here. Only send request and handle errors. https://packagephobia.com/result?p=graphql-request (756kB) https://packagephobia.com/result?p=graphql (1.28MB) Here I replaced it with fetch from undici. Happily codegen have an option to generate generic sdk with own requester function. In the future undici may even be replaced with builtin into node version.
TrySound
force-pushed
the
drop-graphql-request
branch
from
4333879
to
c522651
Compare
|
.husky/_/husky.sh file is back! 😅 |
|
It's a ghost of husky 👻 🐕 |
renatorib
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql-request is big package and depends on graphql. Practically it does not do anything here. Only send request and handle errors.
https://packagephobia.com/result?p=graphql-request (756kB) https://packagephobia.com/result?p=graphql (1.28MB)
Here I replaced it with fetch from undici. Happily codegen have an option to generate generic sdk with own requester function.
In the future undici may even be replaced with builtin into node version.