Drop graphql-tag #12
Merged
Drop graphql-tag #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphql-tag is tagged template which parses and normalizes queries inside. In generated schema it means running parser in runtime. Though why do we need to parse when we already have compiler to do all the job. Here I switched to "string" document mode to generate template literals without any tags. So there is no more runtime overhead. The only issue is duplicated fragments which break pinned posts query. dedupeFragments helps to solve this by removing dependencies from fragments and listing them all in queries.
renatorib
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphql-tag is tagged template which parses and normalizes queries inside. In generated schema it means running parser in runtime. Though why do we need to parse when we already have compiler to do all the job.
Here I switched to "string" document mode to generate template literals without any tags. So there is no more runtime overhead.
The only issue is duplicated fragments which break pinned posts query. dedupeFragments helps to solve this by removing dependencies from fragments and listing them all in queries.