Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed backend method #128

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Typed backend method #128

wants to merge 24 commits into from

Conversation

noam-honig
Copy link
Collaborator

@noam-honig noam-honig commented Sep 30, 2022

  • complete failing test
  • support decorators for parameters of backend methods
  • create a sample of static backend method vs new backend method style
  • review api types

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Base: 88.24% // Head: 88.30% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (5489d50) compared to base (7d467a5).
Patch coverage: 90.05% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   88.24%   88.30%   +0.05%     
==========================================
  Files          36       36              
  Lines        3234     3351     +117     
  Branches      650      672      +22     
==========================================
+ Hits         2854     2959     +105     
- Misses        222      227       +5     
- Partials      158      165       +7     
Impacted Files Coverage Δ
projects/core/src/server-action.ts 80.08% <85.18%> (-0.59%) ⬇️
projects/core/src/column.ts 93.67% <90.47%> (-1.99%) ⬇️
...jects/core/src/remult3/RepositoryImplementation.ts 87.35% <91.56%> (+0.39%) ⬆️
projects/core/src/remult3/DecoratorReplacer.ts 92.30% <100.00%> (+5.64%) ⬆️
projects/core/src/remult-proxy.ts 50.00% <0.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@noam-honig noam-honig self-assigned this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants