Work on #179

remult · Apr 14, 2023 · e3f0f78 · e3f0f78
1 parent 8f2127d
commit e3f0f78
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 4 deletions.
diff --git a/core-api/src/valueConverters.d.ts b/core-api/src/valueConverters.d.ts
@@ -5,6 +5,7 @@ export declare class ValueConverters {
     static readonly DateOnlyString: ValueConverter<Date>;
     static readonly Boolean: ValueConverter<Boolean>;
     static readonly Number: ValueConverter<number>;
+    static readonly String: ValueConverter<String>;
     static readonly Integer: ValueConverter<number>;
     static readonly Default: Required<ValueConverter<any>>;
     static readonly JsonString: ValueConverter<any>;

diff --git a/projects/core/src/remult3/RepositoryImplementation.ts b/projects/core/src/remult3/RepositoryImplementation.ts
@@ -1957,10 +1957,7 @@ export function decorateColumnSettings<valueType>(settings: FieldOptions<any, va
     if (settings.valueType == String) {
         let x = settings as unknown as FieldOptions<any, String>;
         if (!settings.valueConverter)
-            x.valueConverter = {
-                toJson: x => x,
-                fromJson: x => x
-            };
+            x.valueConverter = ValueConverters.String;
     }
 
     if (settings.valueType == Number) {

diff --git a/projects/core/src/shared-tests/db-tests.db-tests.ts b/projects/core/src/shared-tests/db-tests.db-tests.ts
@@ -28,6 +28,15 @@ testAll("what", async ({ remult, createEntity }) => {
     await (await createEntity(stam)).create({ id: 1, title: 'noam' }).save();
     expect(await remult.repo(stam).count()).toBe(1);
 }, false);
+testAll("data types", async ({ remult, createEntity }) => {
+    let r = await (await createEntity(stam)).create({
+        id: 1,
+        //@ts-ignore
+        title: 42
+    }).save();
+    expect(r.title).toEqual("42");
+
+}, false);
 testAll("filter works on all db",
     async ({ createEntity }) => {
         let s = await entityWithValidations.create4RowsInDp(createEntity);

diff --git a/projects/core/src/valueConverters.ts b/projects/core/src/valueConverters.ts
@@ -164,6 +164,16 @@ export class ValueConverters {
       },
       inputType: InputTypes.number
 
+    }
+  static readonly String: ValueConverter<String> =
+    {
+      fromDb: enforceString,
+      toDb: enforceString,
+      fromJson: enforceString,
+      toJson: enforceString,
+      fromInput: enforceString,
+      toInput: enforceString,
+
     }
   static readonly Integer: ValueConverter<number> =
     {
@@ -206,4 +216,11 @@ export class ValueConverters {
     toInput: x => ValueConverters.JsonString.toJson(x),
     fieldTypeInDb: 'json'
   }
+}
+function enforceString(value: string) {
+  if (value === null || value === undefined)
+    return value;
+  if (typeof (value) !== "string")
+    return (value as any).toString()
+  return value;
 }