Skip to content

Commit

Permalink
updated todo
Browse files Browse the repository at this point in the history
  • Loading branch information
yoni-rapoport committed May 5, 2024
1 parent 59936e8 commit 73792aa
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions projects/core/src/remult3/remult3.ts
Expand Up @@ -827,9 +827,9 @@ export type ClassFieldDecorator<entityType, valueType> = (

//y2 - soft-delete-discussion https://discord.com/channels/975754286384418847/1230386433093533698/1230386433093533698

//y1 - In the esm version of our tutorial - the imports are automatically .ts and not .js in react and not in vue
//y1 - consider id to also support keyof (id:['company','index']) - had problem with | (keyof Partial<entityType>)[] & `entity`
//y2 - readonly key: keyof MembersOnly<entityType> & string
//y1 TODO - In the esm version of our tutorial - the imports are automatically .ts and not .js in react and not in vue
//y1 TODO - consider id to also support keyof (id:['company','index']) - had problem with | (keyof Partial<entityType>)[] & `entity`
//y1 TODO - readonly key: keyof MembersOnly<entityType> & string

//y1 - talk about insert / update / delete with relations
/*
Expand Down Expand Up @@ -857,7 +857,6 @@ export type ClassFieldDecorator<entityType, valueType> = (
//p1 - article on displayValue including it's definition for entities that is used in relations
//p2 -fix remult admin not to load the html into memory until used

//y2 - JY suggestion of having generate as part of the ensure schema - not sure
//y2 - currently for string fields we default for 255 in knex (which is their default) why not just use text (varchar max) - and only use exact length when one is provided?

//p2 - create foreign key constraints in user code - https://codesandbox.io/p/devbox/fk-validator-tdshcs
Expand Down

0 comments on commit 73792aa

Please sign in to comment.