Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when no operation command, execute the dev in the remix cli #9420

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

soartec-lab
Copy link
Contributor

@soartec-lab soartec-lab commented May 11, 2024

Currently, remix occurred error when we not give operator command to remix cli

$ npx remix 
TypeError: Cannot read properties of undefined (reading 'startsWith')
    at Object.run (/app/packages/remix-dev/dist/cli/run.js:171:17)
    at Object.<anonymous> (/app/packages/remix-dev/dist/cli.js:16:11)
    at Module._compile (node:internal/modules/cjs/loader:1358:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
    at Module.load (node:internal/modules/cjs/loader:1208:32)
    at Module._load (node:internal/modules/cjs/loader:1024:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12)
    at node:internal/main/run_main_module:28:49

Because, there are parts of cli that expect operation command to always exist. We originally expect the shortcut to the dev command to run, so I modified it.

  • Docs
  • Tests

Testing Strategy:

I added tests so, you can check with run test runner.

pnpm jest packages/remix-dev/__tests__/cli-test.ts

Or, package build and run cli.

pnpm build
node packages/remix-dev/dist/cli.js 

Copy link

changeset-bot bot commented May 11, 2024

⚠️ No Changeset found

Latest commit: 16e3bbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants