Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post-release workflows #9409

Merged
merged 1 commit into from May 10, 2024
Merged

Conversation

brophdawg11
Copy link
Contributor

I noticed that CI wasn't commenting on issues after releases recently, and it looks like the Find Package job was failing due to a missing npm->pnpm update so it was looking for a package-lock.json file and erroring out: https://github.com/remix-run/remix/actions/runs/8818933926/job/24209000833

I also commented out the deployments and stacks tests since I don't think they've passed in quite some time. Maybe after things simplify in the next version we can revisit that idea - would be great to have those running reliably again - even if on a subset of platforms: https://github.com/remix-run/remix/actions/runs/8162173613

Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: 8a80130

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 merged commit 30a994e into main May 10, 2024
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/update-release-workflow branch May 10, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant