Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(remix-dev/vite): fix typo in resolve-file-url.ts #9373

Closed
wants to merge 1 commit into from

Conversation

eltociear
Copy link
Contributor

explictly -> explicitly

  • Docs
  • Tests

Testing Strategy:

Copy link

changeset-bot bot commented May 4, 2024

⚠️ No Changeset found

Latest commit: 6472b90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11
Copy link
Contributor

Thanks for the PR! Sorry to be pedantic, but would you mind rebasing this and pointing to dev since it touches source code files (even if only updating a comment)?

@eltociear eltociear changed the base branch from main to dev May 6, 2024 15:57
@eltociear eltociear changed the base branch from dev to main May 6, 2024 15:58
@eltociear eltociear closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants