Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change single fetch type override recommendation #9336

Merged
merged 1 commit into from May 1, 2024

Conversation

brophdawg11
Copy link
Contributor

Closes #9330

Copy link

changeset-bot bot commented Apr 29, 2024

⚠️ No Changeset found

Latest commit: b7bc024

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcattori
Copy link
Contributor

pcattori commented May 1, 2024

The official docs for tsconfig types only specify @types packages as being supported. Seems like it also works for other packages/paths without @types prefix, but unclear if this is intentional or something that isn't part of the contract and could change without warning in subsequent TS releases. I think we should still go with this since its meant to be a temporary bridge for migrations/upgrades and seems extremely unlikely that TS would change this overnight without warning during this temporary period.

@pcattori pcattori merged commit da96d35 into main May 1, 2024
2 checks passed
@pcattori pcattori deleted the brophdawg11/single-fetch-types branch May 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single fetch: loader type us unknown
2 participants