Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ?url to CSS import in Tailwind docs #9329

Merged
merged 1 commit into from Apr 29, 2024

Conversation

joonmo-you
Copy link
Contributor

The official documentation provided by Tailwind suggests adding a query string at the end of the path to the Tailwind file.
A Remix application doesn't properly import the Tailwind file without the query string.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 27, 2024

Hi @joonmo-you,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

Copy link

changeset-bot bot commented Apr 27, 2024

⚠️ No Changeset found

Latest commit: f1f0fc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 27, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@markdalgleish markdalgleish merged commit 575d858 into remix-run:main Apr 29, 2024
2 checks passed
@markdalgleish markdalgleish changed the title docs: update tailwind import with additional query string based on ta… Add ?url to CSS import in Tailwind docs Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants