Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dest already exists error during Vite build #9305

Merged
merged 1 commit into from Apr 25, 2024

Conversation

markdalgleish
Copy link
Member

This fixes the issue raised in #9239.

This issue occurs when a server asset is present in the client build but isn't present in any of the client manifest's assets arrays. Unfortunately I wasn't able to work out why this can happen, but we can still handle this case regardless.

The list of client assets was only used to determine whether to move a server asset or remove it. This means it's safe to expand the list of client assets to be the list of all files in the client build, regardless of whether they're considered assets or not. The server asset detection logic remains the same so we won't be moving additional files.

Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: 9818ff2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit 5f144d5 into dev Apr 25, 2024
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/fix-dest-already-exists branch April 25, 2024 21:50
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev vite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants