Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vite: typesafe server build #8844

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

vite: typesafe server build #8844

wants to merge 2 commits into from

Commits on Feb 22, 2024

  1. vite: typesafe server build

    @pcattori
    pcattori committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4106883 View commit details
    Browse the repository at this point in the history

  2. wip 

    I think `vite-basename-test` tests that are failing are sharing
resources that should be isolated. Right now we're relying on
side-effects for setting `port` and `cwd` between tests which I think is
the root cause of the error especially since the only test for `express
build` that passes is the one that _doesn't_ share resources with other
tests.

Haven't looked into other failures, but my guess is its the same thing.
Probably would be fixed if we use our new Vite test fixtures.
    @pcattori
    pcattori committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b4d5e62 View commit details
    Browse the repository at this point in the history