Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template(vite-cloudflare): Add _routes.json, _headers and .dev.vars to .gitignore #8722

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lasseklovstad
Copy link

@lasseklovstad lasseklovstad commented Feb 8, 2024

👋 Hey, after testing the vite cloudflare template and deployed it I found some minor issues. It took me maybe 2 hours to find out to set Cloudflare settings 'Build output directory' to 'build/client'. Other then that is went smooth.

  • Added .dev.vars to .gitignore so you don't push your development env variables
  • After looking at cloudflare-pages template I saw _routes.json and _headers files. Don't see why they shouldn't be added to mirror the template for cloudflare.

Copy link

changeset-bot bot commented Feb 8, 2024

⚠️ No Changeset found

Latest commit: 555372b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 8, 2024

Hi @lasseklovstad,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 8, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Contributor

@arjunyel arjunyel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified with a Cloudflare support engineer on Discord that these values are correct https://discord.com/channels/595317990191398933/789155108529111069/1212105133228564490

@mw10013
Copy link

mw10013 commented Feb 28, 2024

@lasseklovstad : Thank you for this. Seems to have fixed a production issue for me where assets were not being found. Much gratitude for your painstaking work in tracking this down.

@@ -3,5 +3,6 @@ node_modules
/.cache
/build
.env
.dev.vars
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could also make the same change for the cloudflare-pages and cloudflare-workers templates.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those templates won't be maintained anymore

@jwaltz
Copy link
Contributor

jwaltz commented Mar 12, 2024

Similar to @mw10013, I was having issues with asset requests returning 404 in production. This seems to have resolved the issue. Hope it gets merged soon. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants