New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template(vite-cloudflare): Add _routes.json, _headers and .dev.vars to .gitignore #8722
base: main
Are you sure you want to change the base?
template(vite-cloudflare): Add _routes.json, _headers and .dev.vars to .gitignore #8722
Conversation
|
Hi @lasseklovstad, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified with a Cloudflare support engineer on Discord that these values are correct https://discord.com/channels/595317990191398933/789155108529111069/1212105133228564490
@lasseklovstad : Thank you for this. Seems to have fixed a production issue for me where assets were not being found. Much gratitude for your painstaking work in tracking this down. |
templates/vite-cloudflare/.gitignore
Outdated
@@ -3,5 +3,6 @@ node_modules | |||
/.cache | |||
/build | |||
.env | |||
.dev.vars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could also make the same change for the cloudflare-pages
and cloudflare-workers
templates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those templates won't be maintained anymore
Similar to @mw10013, I was having issues with asset requests returning 404 in production. This seems to have resolved the issue. Hope it gets merged soon. Thanks! |
👋 Hey, after testing the vite cloudflare template and deployed it I found some minor issues. It took me maybe 2 hours to find out to set Cloudflare settings 'Build output directory' to 'build/client'. Other then that is went smooth.