Add support for the OPTIONS verb #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run_request() method instead of the dynamically-generated method associated with the verb name (Faraday.options is a different thing - see lostisland/faraday#305)
zacharywelch
approved these changes
Nov 3, 2017
lib/her/api.rb
Outdated
| @@ -89,19 +89,26 @@ def request(opts={}) | |||
| path = opts.delete(:_path) | |||
| headers = opts.delete(:_headers) | |||
| opts.delete_if { |key, value| key.to_s =~ /^_/ } # Remove all internal parameters | |||
| response = @connection.send method do |request| | |||
| # Faraday doesn't support the OPTIONS verb because of a name collision with an internal options method | |||
There was a problem hiding this comment.
do we want to put these comments underneath if method == :options like we do for if method == :get?
|
@zacharywelch I decided to bump to version 0.10.0 rather than 0.9.1 because this release includes your refactor of attributes which is a relatively big chunk of stuff. Hope ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the OPTIONS verb, which requires us to use Faraday's run_request() method instead of the dynamically-generated method associated with the verb name (Faraday.options is a different thing - see lostisland/faraday#305)
@zacharywelch are you ok for me to merge into master and push a 0.9.1 gem (need it for a project we're working on)?