Adds Faraday options "timeout" and "open_timeout" accessible in her config

[abhikalakuntla]

Contrary to the the comments in this issue: #120, the options timeout and open_timeout are not being accepted by Her.

Github page for Faraday

[SirRawlins]

Any reason this hasn't been merged in?

[abhikalakuntla]

bump

[edtjones]

hi @abhikalakuntla I've just got commit access on this repo and plan to get back on track with maintenance over time - will be in touch soon!

[abhikalakuntla]

@edtjones hi, any update? :)

[edtjones]

@abhikalakuntla sorry for the delay.

@ticktricktrack this feels like one which should be easy to merge. Do you agree?

[abhikalakuntla]

bump

[edtjones]

Sorry you've had to chase. Will review and merge tomorrow. Happy new year!

…

-- Sent from my phone: please forgive the brevity. Ed Jones

On 5 Jan 2017, at 02:52, abhikalakuntla ***@***.***> wrote: bump — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[edtjones]

@abhikalakuntla I've just released version 0.8.4 with this PR merged. I'm really grateful for the input - thankyou.

[abhikalakuntla]

Thank you :)

[SirRawlins]

Sweet job on getting this merged in! Was running off @abhikalakuntla's branch so I had this support, nice to be back on the upstream.

Good job folks!

[edtjones]

Thanks @SirRawlins - would be delighted to have whatever input you have time for.

[etiennebarrie]

I can't seem to be able to pass timeout and open_timeout directly to Her::API#setup with Faraday 0.11.0, this is the backtrace I get:

~/.gem/ruby/2.3.1/gems/faraday-0.11.0/lib/faraday/options.rb:31:in `block in update': undefined method `timeout=' for #<Faraday::ConnectionOptions:0x007fd289aecf50> (NoMethodError)
Did you mean?  timeout
	from ~/.gem/ruby/2.3.1/gems/faraday-0.11.0/lib/faraday/options.rb:20:in `each'
	from ~/.gem/ruby/2.3.1/gems/faraday-0.11.0/lib/faraday/options.rb:20:in `update'
	from ~/.gem/ruby/2.3.1/gems/faraday-0.11.0/lib/faraday/options.rb:52:in `merge'
	from ~/.gem/ruby/2.3.1/gems/faraday-0.11.0/lib/faraday/connection.rb:61:in `initialize'
	from ~/.gem/ruby/2.3.1/gems/faraday-0.11.0/lib/faraday.rb:67:in `new'
	from ~/.gem/ruby/2.3.1/gems/faraday-0.11.0/lib/faraday.rb:67:in `new'
	from ~/.gem/ruby/2.3.1/gems/her-0.8.4/lib/her/api.rb:76:in `setup'

I was able to fix it by setting the two options inside the block instead of using them as parameters instead, as mentioned in lostisland/faraday#417 (comment):

timeout = options.delete(:timeout) || 5
open_timeout = options.delete(:open_timeout) || 1
Her::API.setup(options) do |connection|
  connection.options.timeout = timeout
  conn.options.open_timeout = open_timeout
end

so I'm not sure :timeout and :open_timeout should be in FARADAY_OPTIONS.

[edtjones]

@abhikalakuntla @SirRawlins can you help with this?

[zacharywelch]

@etiennebarrie believe you're correct and these options were always available as part of the request hash or within the builder as you suggested.

Her::API.setup(url: "https://api.example.com", request: { timeout: 10, open_timeout: 2 })

/cc @abhikalakuntla @SirRawlins