New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(layout): add R globally #671
base: master
Are you sure you want to change the base?
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 614739b:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
==========================================
+ Coverage 98.41% 98.61% +0.20%
==========================================
Files 127 154 +27
Lines 7954 11130 +3176
Branches 724 939 +215
==========================================
+ Hits 7828 10976 +3148
- Misses 123 151 +28
Partials 3 3 ☔ View full report in Codecov by Sentry. |
9b9cd90
to
e0aae74
Compare
e0aae74
to
4c16533
Compare
What version of the library would this import? The version in package.json of the docs project? |
yes the version of the imported remeda library is the one in the package.json of the docs project |
So we'll need a way to make sure that we bump the version in the docs package.json every time we release a version so that the version we provide doesn't diverge from the docs. @cjquines, do you have any idea how to achieve this? I think of another step in the GitHub action that releases to npm: just do |
in that case we should probably fail the publish action anyway? |
Add r globally to docs
Fixes #661
Make sure that you:
src/index.ts
mapping.md
We use semantic PR titles to automate the release process!
https://conventionalcommits.org
PRs should be titled following using the format:
< TYPE >(< scope >)?: description
Available Types:
feat
: new functions, and changes to a function's type that would impact users.fix
: changes to the runtime behavior of an existing function, or refinements to it's type that shouldn't impact most users.perf
: changes to function implementations that improve a functions runtime performance.refactor
: changes to function implementations that are neitherfix
norperf
test
: tests-only changes (transparent to users of the function).docs
: changes to the documentation of a function or the documentation site.build
,ci
,style
,chore
, andrevert
: are only relevant for the internals of the library.For scope put the name of the function you are working on (either new or
existing).