-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add example with vuejs-redux #249
Conversation
Sorry this took so long. After comparing the two Vue demos, I much prefer your example. Rather than binding a single store to Vue, your library also uses a Provider and passes in the store. I believe is more flexible, and more in line with where state management will be headed in the near future. Could you change the PR to completely replace the current Vue demo link in the README instead? Also, if you're interested, we could always use a Vue example under recipes. |
Thank you for your feed back ! Vuejs-redux use scoped slots (a.k.a render props (or render children)) in react because HOC are not idiomatic in Vue and leads to a lot of issues. I do this as soon as possible. |
Replace the vue example in the Readme
5a858c2
to
aaf6f82
Compare
If you have any issues/questions in your repo that are related to the vue integration. You can tag me in it and I will be happy to resolve them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, looks good 👍
Hi,
I am the creator of vuejs-redux. Vue/Redux binding that use scoped slots (native and documented feature of Vue). I forked the and edited the codesandbox to use my plugin and I added it in the readme. I'm not sure of the best integration in it.