Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example with vuejs-redux #249

Merged
merged 6 commits into from
Mar 7, 2018
Merged

add example with vuejs-redux #249

merged 6 commits into from
Mar 7, 2018

Conversation

titouancreach
Copy link
Contributor

@titouancreach titouancreach commented Mar 6, 2018

Hi,

I am the creator of vuejs-redux. Vue/Redux binding that use scoped slots (native and documented feature of Vue). I forked the and edited the codesandbox to use my plugin and I added it in the readme. I'm not sure of the best integration in it.

@ShMcK ShMcK added the docs label Mar 7, 2018
@ShMcK
Copy link
Member

ShMcK commented Mar 7, 2018

Sorry this took so long. After comparing the two Vue demos, I much prefer your example.

Rather than binding a single store to Vue, your library also uses a Provider and passes in the store. I believe is more flexible, and more in line with where state management will be headed in the near future.

Could you change the PR to completely replace the current Vue demo link in the README instead?

Also, if you're interested, we could always use a Vue example under recipes.

@titouancreach
Copy link
Contributor Author

Thank you for your feed back ! Vuejs-redux use scoped slots (a.k.a render props (or render children)) in react because HOC are not idiomatic in Vue and leads to a lot of issues.
I'm also interested in making a recipe !

I do this as soon as possible.

Replace the vue example in the Readme
@titouancreach
Copy link
Contributor Author

If you have any issues/questions in your repo that are related to the vue integration. You can tag me in it and I will be happy to resolve them.

Copy link
Member

@ShMcK ShMcK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, looks good 👍

@ShMcK ShMcK merged commit 547b0f2 into rematch:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants