Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mail): add admin and env setup for mail #364

Open
wants to merge 1,004 commits into
base: master
Choose a base branch
from

Conversation

lwhiteley
Copy link
Contributor

@lwhiteley lwhiteley commented Nov 12, 2016

  • ability to setup mail settings from env
  • ability to setup mail settings from admin panel
  • mail config from admin panel will take precedence if completely configured
curl -d '{ "to": "test@gmail.com", "message": "test", "subject": "email from relax" }'  -H "Content-Type: application/json" localhost:8080/send-email

mail-settings

TODO:

  • this endpoint may need csurf protection to ensure only the application can send emails

Other considerations::

  • probably not exposing send-email url unauthenticated and only expose it for admin use
  • other areas that need to send emails should do so from the backend based on a larger flow. for eg. creating a new user account can send an email based on a template

piamancini and others added 30 commits October 3, 2016 11:25
Now backers and sponsors on opencollective will appear on your readme automatically. an example of how it'll look https://github.com/apex/apex#backers
Added backers and sponsors from OpenCollective
bruno12mota and others added 28 commits November 17, 2016 12:50
update

chore: remove literals

use usersCount instead of initialized bit

update

cleanup
auto redirect to init page if new instance
chore: cleanup mail settings container

chore: fix lint

feat(mail): read default mail settings from env

update

update

update

chore(mail): move mail send to helper func

chore: use non async loop to avoid race condition

chore: namespace mail settings in config

chore(settings): add helper to map settings ids

add missing file

chore(mail): update error message

merge

update

update

update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants