Added Recent File Menu #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenMotor now tracks recently opened files and lets you easily return to them.
reilleya
requested changes
May 23, 2023
|
|
||
| def addRecentFile(self, filepath): | ||
| recentFilepaths = [] | ||
| too_long = False |
| def __init__(self, filepath, manager): | ||
| super().__init__() | ||
| self.manager = manager | ||
| tail , self.name = os.path.split(filepath) |
| @@ -24,6 +25,10 @@ def __init__(self, app): | |||
| self.fileName = None | |||
|
|
|||
| self.newFile() | |||
|
|
|||
| self.recentlyOpenedFiles = [] | |||
| self.recentFiles = getConfigPath() + 'recentfiles.txt' | |||
There was a problem hiding this comment.
It is a pretty minor difference here, but I'd prefer the use of a yaml file with the same fileIO setup I used for preferences. That is consistent with the rest of the application and gets us things like migrations if we ever need them. You should just be able to stick a list in one of them.
There was a problem hiding this comment.
Another thing: concatenating file paths like that isn't always good practice because different operating systems might have different schemes for it. The safest way is with os.path.join. I know I used the + for this in the application myself, but I have learned since then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenMotor now tracks recently opened files and lets you easily return to them.