forked from ngruver/llmtime
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bsweger/labmeeting organization #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added latest gpt models, mistral local and mistral api
In some shells (e.g., zsh), the bracket syntax throws an error without the quotes.
Although demo.ipynb seems to be an older version of the example code in demo.py, let's fix up the model list so it won't throw errors when people run it. - text-davinci-003 is deprecated, and OpenAI recommends gpt-3.5-turbo-instruct instead - team's OpenAI account doesn't have access to gpt-4
Make sure 'parallel' is always in **kwargs and don't pass it in explicitly when calling generate_predictions.
Referencing this iPython extension can cause errors for people running the Jupyter notebook for the first time (some IDEs are smart enough to prompt for an install, but some are not). Because %autoreload isn't really useful for someone running a demo, let's remove it.
This is an optional convenience for people who don't want to store secrets in dotfiles such as .zshrc or .bashrc (or are having trouble doint so).
demo_openai.py is a copy of demo.ipynb, since it will be easier for lab meeting to collaborate outside of a notebook environment.
nickreich
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked this over carefully, commit by commit, and all the changes in bulk. I did not try to run any of the code locally. I don't have any suggested changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to organize the Reich Lab's fork of llmtime for easier collaboration between lab meeting breakout groups.
The first few commits are a result of syncing our fork with the upstream llmtime repo.
After that, there are a series of commits to address the installation pain points we encountered, a bugfix, and an optional way to load environment variables from an
.env
file instead of from dotfiles like.zshrc
and.bashrc
.Lastly, there's a new
demo_openai.py
file that's a non-notebook version ofdemo.ipynb
for us to work from.It's probably easiest to review this one commit-by-commit.