react should be a peer dependency. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise yarn will install react in "@rehooks/window-size/node_modules/react", which will break, as react 16.7.0 does not have hooks yet.
|
I'm going to copy-paste this hook because if I try to use it through npm it tries to use latest stable (which is incorrect). |
|
Be sure to remove the react-dom devDependency as well then. |
I'm only copying index.js ;) |
nitroin
approved these changes
Oct 4, 2019
|
unable to use this hook until this is merged 😰 |
iRayan7
approved these changes
Apr 13, 2020
|
Hey, now that we have React 17, this hook is importing a different version. Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise yarn will install react in "@rehooks/window-size/node_modules/react", which will break, as react 16.7.0 does not have hooks yet.