Fix slug on save (Closes GH-485) #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance someone could take a look at my PR? I also submitted recently issue #509 because the CI pipeline seems to be broken for this repo. Let me know if there is anything I can help with. Thanks in advance for your time. |
|
Changing the method in our refinery app does raise a "stack level too deep" on validarion in case of missing attributes. |
|
@kjoscha I can't reproduce this issue manually on my test installation. If I leave either the title or the body of a blog post empty I get respectively:
Which version of RefineryCMS are you using? and which version of Rails? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also encountering the annoying issue #485 where slugs are not generated and seeing that finally no one created a PR for it I decided to submit this one so things can get finally fixed. Credits go here to @imunteanu and @spotlessicode. A test covering this specific case should also already be available here I believe:
refinerycms-blog/spec/models/refinery/blog/post_spec.rb
Line 244 in 684036e
Thanks in advance for reviewing this PR.