Fix error when clicking on 'save & continue' then changing locale #487
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2018
|
Thanks for your contribution! Could you add a test to confirm your bugfix? |
|
@bricesanchez Sure, no problem. It does require javascript in the capybara test to run correctly. Which js driver do you run in your CI environment? |
|
@cedrtang we're using the Poltergeist gem, so phantomjs |
|
We are now using Chrome headless :D |
|
Hi, I'm having this problem.
By hovering over the "Producto" menu option, the link is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug when using different locales and saving using the "Save & continue editing" button: the URL of the locales switch picker got undefined and an error occur.
The fix is to apply the same behavior as Pages in Refinery using the JS function 'submit_and_continue' in admin.js.erb that changes the locale switch picker URL. If we send back the correct URL parameters after a Post update, it works correctly.