Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declarations for node16/nodenext resolutions #5881

Merged
merged 8 commits into from Apr 24, 2024

Conversation

aliemir
Copy link
Member

@aliemir aliemir commented Apr 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

Changes

Updated import/export statements in target files of tsc to resolve correct declaration files. Currently d.ts files are failing to resolve imports and exports resulting in unexpected errors when importing components and utilities from Refine packages.

Resolves #5827

@aliemir aliemir requested a review from a team as a code owner April 24, 2024 06:15
Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: 7388153

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aliemir aliemir added this to the May Release milestone Apr 24, 2024
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5881 April 24, 2024 06:18 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5881 April 24, 2024 06:20 Inactive
Copy link

cypress bot commented Apr 24, 2024

Passing run #10988 ↗︎

0 342 33 0 Flakiness 0

Details:

Merge 7388153 into 2b6f053...
Project: refine Commit: ec93973b42 ℹ️
Status: Passed Duration: 35:28 💡
Started: Apr 24, 2024 9:41 AM Ended: Apr 24, 2024 10:16 AM

Review all test suite changes for PR #5881 ↗︎

@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5881 April 24, 2024 07:29 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5881 April 24, 2024 07:29 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5881 April 24, 2024 08:22 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5881 April 24, 2024 08:24 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5881 April 24, 2024 08:38 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5881 April 24, 2024 08:41 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5881 April 24, 2024 09:10 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5881 April 24, 2024 09:10 Inactive
@aliemir aliemir changed the base branch from master to releases/may April 24, 2024 09:36
@aliemir aliemir requested a review from a team as a code owner April 24, 2024 09:36
@aliemir aliemir merged commit ba719f6 into releases/may Apr 24, 2024
92 checks passed
@aliemir aliemir deleted the fix/declaration-files-in-node16-resolution branch April 24, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Upgrading from 4.48.0 to 4.49.0 break TypeScript imports in @refinedev/core
2 participants