New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mui): configurable anchorOrigin
for useNotificationProvider
#5876
feat(mui): configurable anchorOrigin
for useNotificationProvider
#5876
Conversation
🦋 Changeset detectedLatest commit: 3f640a0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Yash-271120, thank you for the PR. I think there are some misunderstandings about this issue. Let me try to clarify the changes needed.
- You've made a change to the
notificationProvider
type in@refinedev/core
. We don't need to have anything changed here. useNotificationProvider
of@refinedev/mui
should not accept any more parameters. Only the props likeanchorOrigin
,disableWindowBlurListener
etc. will be replaced by the context ofRefineSnackbarProvider
.- The issue requires changes to the
<RefineSnackbarProvider />
component. We need to pass these default values as default props to the<RefineSnackbarProvider />
. Then those will replace the hardcoded values ofuseNotificationProvider
.
Let me know if you can update this PR to reflect the changes properly 🙏
@aliemir what if we remove the harcoded code for |
That was actually what I was trying to say 😅 These values will be set as default props of Can you make the required changes in this PR? I'll mark this PR to be included in our May release if you can provide an update 🙏 |
Hey @aliemir |
anchorOrigin
for useNotificationProvider
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
Anchor position,preventDuplicate,disableWindowBlurListener are hard coded in mui useNotificationsProvider
What is the new behavior?
these values can now be provided as per usage
fixes #5847
Notes for reviewers