Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Changed type of options in translate function of i18nProvider #5869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bzhn
Copy link
Contributor

@bzhn bzhn commented Apr 19, 2024

Example with options: any gives me the following error:

Type '(key: string, options?: any) => string | TFunctionDetailedResult<string, any>' is not assignable to type 'TranslateFunction'.
  Type 'string | TFunctionDetailedResult<string, any>' is not assignable to type 'string'.
    Type 'TFunctionDetailedResult<string, any>' is not assignable to type 'string'.ts(2322)

I found solution in a following file that fixes the error:

https://github.com/Fgruntjes/WFK-Finance/blob/7b6c817b913f89db6197c705d34e260aaf7ed726/frontend/src/i18n-provider/useI18nProvider.ts#L5

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes # (issue)

Notes for reviewers

I'm following the guide at the page and getting error. The error is fixed when I change options?: any to options?: $Dictionary<unknown>.

The screenshot of an error:

image

Example with `options: any` gives me the following error:

```
Type '(key: string, options?: any) => string | TFunctionDetailedResult<string, any>' is not assignable to type 'TranslateFunction'.
  Type 'string | TFunctionDetailedResult<string, any>' is not assignable to type 'string'.
    Type 'TFunctionDetailedResult<string, any>' is not assignable to type 'string'.ts(2322)
```

I found solution in a following file that fixes the error:

https://github.com/Fgruntjes/WFK-Finance/blob/7b6c817b913f89db6197c705d34e260aaf7ed726/frontend/src/i18n-provider/useI18nProvider.ts#L5
@bzhn bzhn requested a review from a team as a code owner April 19, 2024 14:42
Copy link

changeset-bot bot commented Apr 19, 2024

⚠️ No Changeset found

Latest commit: 5bb5e87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Apr 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5bb5e87. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant