Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nestjs-query): implement getApiUrl #5844

Closed
wants to merge 2 commits into from

Conversation

yess-wee
Copy link

@yess-wee yess-wee commented Apr 12, 2024

changed ,
// getApiUrl: () => {
// throw Error("Not implemented on refine-nestjs-query data provider.");
// },

to

getApiUrl: () => {
return client.getApiUrl();
},

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes #5606

Notes for reviewers

changed ,
// getApiUrl: () => {
    //   throw Error("Not implemented on refine-nestjs-query data provider.");
    // },

to

getApiUrl: () => {
    return client.getApiUrl();
},
@yess-wee yess-wee requested a review from a team as a code owner April 12, 2024 11:52
Copy link

changeset-bot bot commented Apr 12, 2024

⚠️ No Changeset found

Latest commit: f4bc450

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@BatuhanW BatuhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yess-wee please read our contribution guide. Make sure you add changeset, tests and also commit message should follow commit convention.

@BatuhanW BatuhanW changed the title [FEAT]: implement getApiUrl in @refinedev/nestjs-query #5606 feat(nestjs-query): implement getApiUrl in @refinedev/nestjs-query #5606 Apr 15, 2024
@BatuhanW BatuhanW changed the title feat(nestjs-query): implement getApiUrl in @refinedev/nestjs-query #5606 feat(nestjs-query): implement getApiUrl #5606 Apr 15, 2024
@BatuhanW BatuhanW changed the title feat(nestjs-query): implement getApiUrl #5606 feat(nestjs-query): implement getApiUrl Apr 15, 2024
Copy link

nx-cloud bot commented Apr 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f4bc450. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@omeraplak omeraplak added this to the May Release milestone Apr 17, 2024
@aliemir
Copy link
Member

aliemir commented Apr 25, 2024

@yess-wee Any chance for you to work on this PR? We're hoping to include this in our May release if you can resolve the errors and provide a changeset 🙏

@aliemir
Copy link
Member

aliemir commented May 2, 2024

Closing this due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: implement getApiUrl in @refinedev/nestjs-query
4 participants