New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nestjs-query): implement getApiUrl #5844
Conversation
changed , // getApiUrl: () => { // throw Error("Not implemented on refine-nestjs-query data provider."); // }, to getApiUrl: () => { return client.getApiUrl(); },
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yess-wee please read our contribution guide. Make sure you add changeset, tests and also commit message should follow commit convention.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f4bc450. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
@yess-wee Any chance for you to work on this PR? We're hoping to include this in our May release if you can resolve the errors and provide a changeset 🙏 |
Closing this due to inactivity |
changed ,
// getApiUrl: () => {
// throw Error("Not implemented on refine-nestjs-query data provider.");
// },
to
getApiUrl: () => {
return client.getApiUrl();
},
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
What is the new behavior?
fixes #5606
Notes for reviewers